test: add test fro sequential_cmi_runner#20
Merged
sbillinge merged 1 commit intoPDF-bl:mainfrom Feb 4, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ycexiao
commented
Feb 4, 2026
Contributor
Author
ycexiao
left a comment
ycexiao
left a comment
There was a problem hiding this comment.
@sbillinge, it's ready for review.
| from diffpy.srfit.structure import constrainAsSpaceGroup | ||
| from diffpy.structure.parsers import getParser | ||
| from scipy.optimize import minimize | ||
| from scipy.optimize import least_squares |
Contributor
Author
There was a problem hiding this comment.
The default minimize setting is extremely slow. The time spent is increased from several seconds to several minutes. Switch back to least_squares.
| variable_names : list of str | ||
| The names of the variables to refine. | ||
| """ | ||
| for vname in variable_names: |
Contributor
Author
There was a problem hiding this comment.
Check before applying variables.
| self.adapter = PDFAdapter() | ||
| self.data_for_plot = {} | ||
|
|
||
| def validate_inputs(self): |
Contributor
Author
There was a problem hiding this comment.
Check inputs before running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Add test for
sequential_cmi_runner.What should the reviewer(s) do?
Please see the code.